Page 15 of 17

Re: RCs public previews

Posted: Mon Feb 04, 2019 9:57 pm
by RandomUser
ntnll wrote:
Mon Feb 04, 2019 9:37 am
The function looks for the closest airport, and look for the pertinent ACC. There's not call to SDK, X-plane doesn't provide any acc data.
No calling "XPLMFindNavAid" then?

Re: RCs public previews

Posted: Tue Feb 05, 2019 7:47 am
by ntnll
RandomUser wrote:
Mon Feb 04, 2019 9:57 pm
ntnll wrote:
Mon Feb 04, 2019 9:37 am
The function looks for the closest airport, and look for the pertinent ACC. There's not call to SDK, X-plane doesn't provide any acc data.
No calling "XPLMFindNavAid" then?
XPLMFindNavAid is called globally in order to find the closest airport, but the frequency function doesn't interacts with SDK

Re: RCs public previews

Posted: Tue Feb 05, 2019 11:35 am
by argonius
ntnll wrote:
Mon Jan 28, 2019 9:42 am
argonius wrote:
Sat Jan 26, 2019 11:47 am
Just had a crash of RC23 during approach into LSZH, bug report attached.
/Christian
Last line of the log are the custom command invocation for the flight information. Did you noticed any correlation between the crashes and the custom command?
Sorry for the late response. I can't say that for sure, but I tend to say no, at least the crash would not happen immediately after using a custom command.
I am currently busy with my aircraft upgrade project, thus I did not have time trying to reproduce / verify a correlation with custom commands. I'll do as soon as I find some time :)
/Christian

Re: RCs public previews

Posted: Tue Feb 05, 2019 6:32 pm
by RandomUser
ntnll wrote:
Tue Feb 05, 2019 7:47 am
XPLMFindNavAid is called globally in order to find the closest airport, but the frequency function doesn't interacts with SDK
How often is "FindNavAid" called?

Re: RCs public previews

Posted: Wed Feb 06, 2019 8:26 am
by ntnll
argonius wrote:
Tue Feb 05, 2019 11:35 am
ntnll wrote:
Mon Jan 28, 2019 9:42 am
argonius wrote:
Sat Jan 26, 2019 11:47 am
Just had a crash of RC23 during approach into LSZH, bug report attached.
/Christian
Last line of the log are the custom command invocation for the flight information. Did you noticed any correlation between the crashes and the custom command?
Sorry for the late response. I can't say that for sure, but I tend to say no, at least the crash would not happen immediately after using a custom command.
I am currently busy with my aircraft upgrade project, thus I did not have time trying to reproduce / verify a correlation with custom commands. I'll do as soon as I find some time :)
/Christian

Thanks Christian!
RandomUser wrote:
Tue Feb 05, 2019 6:32 pm
ntnll wrote:
Tue Feb 05, 2019 7:47 am
XPLMFindNavAid is called globally in order to find the closest airport, but the frequency function doesn't interacts with SDK
How often is "FindNavAid" called?
Roughly three minutes

Re: RCs public previews

Posted: Wed Feb 06, 2019 6:19 pm
by RandomUser
ntnll wrote:
Wed Feb 06, 2019 8:26 am
Roughly three minutes
Any chance this could cause a crash when, coincidentially, being near a 1°x 1° dsf tile boundary?

If I understand you correctly, every three minutes, 124th will invoke "XPLMFindNavAid" using the current aircraft latitude and longitude as input parameters and "XPLMNavType = 1" (airports) as inType, match the result with the list of airports in acc.dat and retry if there is no match?

Re: RCs public previews

Posted: Thu Feb 07, 2019 8:14 am
by ntnll
RandomUser wrote:
Wed Feb 06, 2019 6:19 pm
ntnll wrote:
Wed Feb 06, 2019 8:26 am
Roughly three minutes
Any chance this could cause a crash when, coincidentially, being near a 1°x 1° dsf tile boundary?

If I understand you correctly, every three minutes, 124th will invoke "XPLMFindNavAid" using the current aircraft latitude and longitude as input parameters and "XPLMNavType = 1" (airports) as inType, match the result with the list of airports in acc.dat and retry if there is no match?
That's correct. Which is the fp is causing most of the crashs, is it the following?
(EDDV) WRB RANAX EDEGA AMETU SOGMI BOMBI GIGET ABUKA KRH PABLA HERBI MOPAN OLBEN LUTIX BENOT NEMOS VEROX MILPA GIRKU BALSI KOTIT RETNO DOTIG GIROL TUPOX MTG DIVKO VATIR PIVUS SULID SISMO KENAS (LEPA)

Did you ever modified the acc.dat? If yes, please try overwriting it with the default one.

In the last tests I made, I was unable to replicate the issue, I'll try again this evening.

Re: RCs public previews

Posted: Fri Feb 08, 2019 12:17 am
by RandomUser
ntnll wrote:
Thu Feb 07, 2019 8:14 am
That's correct. Which is the fp is causing most of the crashs, is it the following?
(EDDV) WRB RANAX EDEGA AMETU SOGMI BOMBI GIGET ABUKA KRH PABLA HERBI MOPAN OLBEN LUTIX BENOT NEMOS VEROX MILPA GIRKU BALSI KOTIT RETNO DOTIG GIROL TUPOX MTG DIVKO VATIR PIVUS SULID SISMO KENAS (LEPA)
Crashes vary with flight plans and there is no reliable indication what could cause them.
Did you ever modified the acc.dat? If yes, please try overwriting it with the default one.
No. My only mod was adding Warszawa Center, but that one is default by now.
In the last tests I made, I was unable to replicate the issue, I'll try again this evening.
As I've posted before, I've managed to complete the flight on another day.

Did you get center handoffs during your test?


And have you considered redesigning the center lookup logic?
My first idea was using the real airspace boundaries and point-in-polygon logic, but this is very hard to implement
My second idea is using X-Plane's map grid and assign a center and frequency to each tile (could be reasonably accurate), store it in a database similar to acc.dat and then have 124th somehow determine which tile the aircraft is on and simply read the associated center's frequency from said database.
This would be a lot faster than basically continuously scanning any surrounding airports for the ones that are in the database, but so far, I have not found a quick and easy way to get the number of the scenery tile that the user aircraft is on at the moment.

Re: RCs public previews

Posted: Fri Feb 08, 2019 4:02 pm
by ntnll
RandomUser wrote:
Fri Feb 08, 2019 12:17 am


Did you get center handoffs during your test?


And have you considered redesigning the center lookup logic?
My first idea was using the real airspace boundaries and point-in-polygon logic, but this is very hard to implement
My second idea is using X-Plane's map grid and assign a center and frequency to each tile (could be reasonably accurate), store it in a database similar to acc.dat and then have 124th somehow determine which tile the aircraft is on and simply read the associated center's frequency from said database.
This would be a lot faster than basically continuously scanning any surrounding airports for the ones that are in the database, but so far, I have not found a quick and easy way to get the number of the scenery tile that the user aircraft is on at the moment.


I have handoffs now, that I fixed the bug in the built I'm working on.
At the time it was the most efficient way to determinate the ACC. All the other ways are too complex. Now there are too much critical bugs to fix, I'll dedicate my efforts to improve those functionality later, when the critical bug will be fixed.

Re: RCs public previews

Posted: Fri Feb 08, 2019 9:55 pm
by dannyblood
Hi,

I am not in Beta test Group but want to report here a CTD from XP 11.31 (Win10) caused by 124th ATC (RC23). Happend with request runway change before decent to ATC click on other runway -> OK -> click on the runway I would change -> CTD (Flight EDDT - EDDL)
Last lines of XP log

124thATC v2.0-a60RC23 22:24:29: apt parser: found: 'EDDL'
124thATC v2.0-a60RC23 22:24:29: apt parser: Runway found: '5' '05R' lat'51.279621' lon'6.752037' heading 52.70
124thATC v2.0-a60RC23 22:24:29: apt parser: Runway found: '23' '23L' lat'51.295925' lon'6.786254' heading 232.70
124thATC v2.0-a60RC23 22:24:29: apt parser: Runway length: 1.6144 magnetic variation: -2.55
124thATC v2.0-a60RC23 22:24:29: apt parser: Runway found: '5' '05L' lat'51.283669' lon'6.748674' heading 52.70
124thATC v2.0-a60RC23 22:24:29: apt parser: Runway found: '23' '23R' lat'51.298382' lon'6.779555' heading 232.70
124thATC v2.0-a60RC23 22:24:29: apt parser: Runway length: 1.4569 magnetic variation: -2.55
124thATC v2.0-a60RC23 22:24:29: apt parser: atisFrequency found: '12377'
124thATC v2.0-a60RC23 22:24:29: apt parser: deliveryFrequency found: '12177'
124thATC v2.0-a60RC23 22:24:29: apt parser: groundFrequency found: '12190'
124thATC v2.0-a60RC23 22:24:29: apt parser: towerFrequency found: '11830'
124thATC v2.0-a60RC23 22:24:29: apt parser: approachFrequency found: '11940'
124thATC v2.0-a60RC23 22:24:29: runway 23L in-use departure (range: 0 0)
124thATC v2.0-a60RC23 22:24:29: runway 23R in-use arrival (range: 0 0)
124thATC v2.0-a60RC23 22:24:29: runway 05R in-use departure (range: 0 0)
124thATC v2.0-a60RC23 22:24:29: runway 05L in-use arrival (range: 0 0)
124thATC v2.0-a60RC23 22:24:29: apt parser: tower frequency on leaving: '11830.000000'
124thATC v2.0-a60RC23 22:24:29: apt parser: total parkings found: 30
124thATC v2.0-a60RC23 22:24:29: -------------------------- Parser ended!!! --------------------------
124thATC v2.0-a60RC23 22:24:29: Flight plan status for Lufthansa 196 @D-AXLA@ (size 13): RW (2) BRANE (0) HLZ (2) OSN (2) HMM (2) XAMOD (2) DL422 (2) DL426 (2) DL430 (2) DL450 (2) DL455 (2) METMA (5) Runway 23R (6)
124thATC v2.0-a60RC23 22:24:32: Entering FlightPlan Backup status function
124thATC v2.0-a60RC23 22:24:32: Choose target runway manually...
124thATC v2.0-a60RC23 22:24:32: Set matching runway...
124thATC v2.0-a60RC23 22:24:32: Take preferred arrival runway
124thATC v2.0-a60RC23 22:24:32: Take targetAirport object
124thATC v2.0-a60RC23 22:24:32: Runway lookup arrival: )
124thATC v2.0-a60RC23 22:24:32: Runway found 0/4: 05R (isDeparture: 0)
124thATC v2.0-a60RC23 22:24:32: Runway found 1/4: 23L (isDeparture: 0)
124thATC v2.0-a60RC23 22:24:32: Runway found 2/4: 05L (isDeparture: 0)
124thATC v2.0-a60RC23 22:24:32: Runway found 3/4: 23R (isDeparture: 0)
124thATC v2.0-a60RC23 22:24:32: Take runway 23L.
124thATC v2.0-a60RC23 22:24:32: Set runway information...
124thATC v2.0-a60RC23 22:24:32: Airport found to set runway height: EDDL (pilot Lufthansa 196 @D-AXLA@, Duesseldorf).
124thATC v2.0-a60RC23 22:24:32: Height of Runway: 146.004791.
124thATC v2.0-a60RC23 22:24:32: Runway information set!
124thATC v2.0-a60RC23 22:24:32: Target runway chosen!
124thATC v2.0-a60RC23 22:24:32: ILS Path set to RWY 23L.
124thATC v2.0-a60RC23 22:24:32: Take arrival runway 23L
124thATC v2.0-a60RC23 22:24:32: Flight plan status for Lufthansa 196 @D-AXLA@ (size 1): Departure (0)


As you can see log ends and no hint for error. Maybe it could help, I found the error in Windows eventviewer:

Faulting application name: X-Plane.exe, version: 11.0.31.0, time stamp: 0x5c4a8f39
Faulting module name: 124thATC64.xpl, version: 0.0.0.0, time stamp: 0x5c3cdb61
Exception code: 0xc0000005
Fault offset: 0x000000000006a969
Faulting process id: 0x2378
Faulting application start time: 0x01d4bfe8b8225174
Faulting application path: F:\X-Plane 11\X-Plane.exe
Faulting module path: F:\X-Plane 11\Resources\plugins\124thATC64\win_x64\124thATC64.xpl
Report Id: dcc67324-e427-4dab-8974-2565c9bf4b66
Faulting package full name:
Faulting package-relative application ID:

XML:

<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
- <System>
<Provider Name="Application Error" />
<EventID Qualifiers="0">1000</EventID>
<Level>2</Level>
<Task>100</Task>
<Keywords>0x80000000000000</Keywords>
<TimeCreated SystemTime="2019-02-08T21:24:33.790152000Z" />
<EventRecordID>19022</EventRecordID>
<Channel>Application</Channel>
<Computer>DESKTOP-H21TE2P</Computer>
<Security />
</System>
- <EventData>
<Data>X-Plane.exe</Data>
<Data>11.0.31.0</Data>
<Data>5c4a8f39</Data>
<Data>124thATC64.xpl</Data>
<Data>0.0.0.0</Data>
<Data>5c3cdb61</Data>
<Data>c0000005</Data>
<Data>000000000006a969</Data>
<Data>2378</Data>
<Data>01d4bfe8b8225174</Data>
<Data>F:\X-Plane 11\X-Plane.exe</Data>
<Data>F:\X-Plane 11\Resources\plugins\124thATC64\win_x64\124thATC64.xpl</Data>
<Data>dcc67324-e427-4dab-8974-2565c9bf4b66</Data>
<Data />
<Data />
</EventData>
</Event>

Many thanks for short feedback.

Best wishes

Re: RCs public previews

Posted: Sun Feb 10, 2019 1:57 pm
by argonius
Hi,

Just did a flight with RC23 from BIEG to BIRK (BRUSI ASKJA ARNAR BLAMI TIBRA). No crash even with using custom commands.

Departure was fine. But I don't understand why the plugin is adding some (IMHO) weird approximation waypoints in transition from STAR to approach. In this flight I have selected STAR TIBR1N and RWY 19. TIBR1N ends at KUSUR and KUSUR is IAF of the ILS approach to RWY19. So, why is the plugin adding two approximation waypoints? You can see the loop it made me fly on the map attached.

Also, the initial descent to FL150 is very early if you compare it to the TOD calculated by Little Navmap (using 1200 fpm in Navmap and in plugin settings).

BR
Christian

Re: RCs public previews

Posted: Sun Feb 10, 2019 8:27 pm
by RandomUser
When flying STARs, I usually ignore vectoring calls.

Ideally, 124th wouldn't vector you at all if the current approach mode is STAR (and only provide speed and alitude clearance), but you'd be able to revert to a vectored approach at any time (to make a short visual final or so).

Speaking of: Can the "Look for SID/STARs" function from the flight plan tool be moved to the controller dialogs?

Something like:
"Request clearance (no SID)"
"Request clearance (pick SID)"
"Request clearance (Auto-SID)"

"Use vectored approach"
"Use STAR approach (pick STAR)"
"Use STAR approach (Auto-STAR)"

Re: RCs public previews

Posted: Mon Feb 11, 2019 10:22 am
by argonius
RandomUser wrote:
Sun Feb 10, 2019 8:27 pm
When flying STARs, I usually ignore vectoring calls.

Ideally, 124th wouldn't vector you at all if the current approach mode is STAR (and only provide speed and alitude clearance), but you'd be able to revert to a vectored approach at any time (to make a short visual final or so).

Speaking of: Can the "Look for SID/STARs" function from the flight plan tool be moved to the controller dialogs?

Something like:
"Request clearance (no SID)"
"Request clearance (pick SID)"
"Request clearance (Auto-SID)"

"Use vectored approach"
"Use STAR approach (pick STAR)"
"Use STAR approach (Auto-STAR)"
I normally ignore it too (but then you normally need to ignore altitude as well and stick to the STAR altitudes, otherwise you end up to high at IAF, like in the example above I was still at FL150). This time I have "obeyed" to show how weird the vectoes given are.

Re: RCs public previews

Posted: Mon Feb 11, 2019 9:57 pm
by RandomUser
argonius wrote:
Mon Feb 11, 2019 10:22 am
I normally ignore it too (but then you normally need to ignore altitude as well and stick to the STAR altitudes, otherwise you end up to high at IAF, like in the example above I was still at FL150). This time I have "obeyed" to show how weird the vectoes given are.
The good thing about 124th is that requests for a cruise altitude change are (almost?) always granted, so if you want to descend on a STAR and don't have clearance to do so yet, simply request a new altitude.

Re: RCs public previews

Posted: Tue Feb 12, 2019 9:21 am
by argonius
RandomUser wrote:
Mon Feb 11, 2019 9:57 pm
The good thing about 124th is that requests for a cruise altitude change are (almost?) always granted, so if you want to descend on a STAR and don't have clearance to do so yet, simply request a new altitude.
Good point, never have thought about. :idea: